-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-8183] Checking for a null value #1676
Conversation
🦋 Changeset detectedLatest commit: a7fa169 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
View your CI Pipeline Execution ↗ for commit a7fa169.
☁️ Nx Cloud last updated this comment at |
Deploying mitosis with
|
Latest commit: |
a7fa169
|
Status: | ✅ Deploy successful! |
Preview URL: | https://595b9d7d.mitosis-9uh.pages.dev |
Branch Preview URL: | https://null-string.mitosis-9uh.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add changesets to your PR, see https://github.com/BuilderIO/mitosis/blob/main/CONTRIBUTING.md#preparing-your-pr (last bullet point) and the following section for the conventional format we use
'@builder.io/mitosis': patch | ||
--- | ||
|
||
check for null string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I push for more elaborate release notes that follow the format in https://github.com/BuilderIO/mitosis/blob/main/CONTRIBUTING.md#changeset-format
so that it's clear what part of Mitosis each change impacts.
In your case, it would be:
check for null string | |
[Builder]: fix null column width crash. |
Description
Please provide the following information:
Checking for a null string
Null values were being passed in for width
Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:
yarn fmt:prettier
.yarn test:update
yarn g:changeset
and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.