Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-8183] Checking for a null value #1676

Merged
merged 1 commit into from
Feb 4, 2025
Merged

[ENG-8183] Checking for a null value #1676

merged 1 commit into from
Feb 4, 2025

Conversation

seunss
Copy link
Contributor

@seunss seunss commented Feb 4, 2025

Description

Please provide the following information:

  • What changes you made:
    Checking for a null string
  • Why you made them, and:
    Null values were being passed in for width
  • Any other useful context:

Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

  • format the codebase: from the root, run yarn fmt:prettier.
  • update all snapshots (in core & CLI): from the root, run yarn test:update
  • add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

@seunss seunss requested a review from samijaber as a code owner February 4, 2025 16:36
@seunss seunss self-assigned this Feb 4, 2025
Copy link

changeset-bot bot commented Feb 4, 2025

🦋 Changeset detected

Latest commit: a7fa169

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/mitosis Patch
@builder.io/mitosis-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Feb 4, 2025

View your CI Pipeline Execution ↗ for commit a7fa169.

Command Status Duration Result
nx run-many --target test ✅ Succeeded 4m 30s View ↗
nx e2e @builder.io/e2e-app ✅ Succeeded 1m 15s View ↗
nx run-many --target build --exclude @builder.i... ✅ Succeeded 2s View ↗
nx build @builder.io/mitosis-site ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-04 21:36:10 UTC

Copy link

cloudflare-workers-and-pages bot commented Feb 4, 2025

Deploying mitosis with  Cloudflare Pages  Cloudflare Pages

Latest commit: a7fa169
Status: ✅  Deploy successful!
Preview URL: https://595b9d7d.mitosis-9uh.pages.dev
Branch Preview URL: https://null-string.mitosis-9uh.pages.dev

View logs

@seunss seunss requested a review from kylefowler February 4, 2025 17:57
Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add changesets to your PR, see https://github.com/BuilderIO/mitosis/blob/main/CONTRIBUTING.md#preparing-your-pr (last bullet point) and the following section for the conventional format we use

@seunss seunss requested a review from samijaber February 4, 2025 18:43
@seunss seunss enabled auto-merge (squash) February 4, 2025 21:30
@seunss seunss merged commit cf666ff into main Feb 4, 2025
14 checks passed
@seunss seunss deleted the null-string branch February 4, 2025 21:36
'@builder.io/mitosis': patch
---

check for null string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I push for more elaborate release notes that follow the format in https://github.com/BuilderIO/mitosis/blob/main/CONTRIBUTING.md#changeset-format

so that it's clear what part of Mitosis each change impacts.

In your case, it would be:

Suggested change
check for null string
[Builder]: fix null column width crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants