-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Non-breaking changes] Chore: Update derive SHA for stacktrie #375
Closed
c98tristan
wants to merge
27
commits into
BuildOnViction:upgrade-core-develop
from
c98tristan:feat/update-trie-to-stacktrie
Closed
[Non-breaking changes] Chore: Update derive SHA for stacktrie #375
c98tristan
wants to merge
27
commits into
BuildOnViction:upgrade-core-develop
from
c98tristan:feat/update-trie-to-stacktrie
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trinhdn2
suggested changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also make sure that the test units are updated alongside with these changes. There are lots of untouched hashing operations in unit tests.
This PR can be marked as non-breaking, and the merge destination needs to be changed from |
c98tristan
changed the title
Chore: Update derive SHA for stacktrie
[Non-breaking] Chore: Update derive SHA for stacktrie
Jul 25, 2023
c98tristan
changed the title
[Non-breaking] Chore: Update derive SHA for stacktrie
[Non-breaking changes] Chore: Update derive SHA for stacktrie
Jul 25, 2023
trinhdn2
approved these changes
Jul 25, 2023
c98tristan
force-pushed
the
feat/update-trie-to-stacktrie
branch
from
July 25, 2023 09:54
08dbcbb
to
72ca227
Compare
trinhdn2
force-pushed
the
feat/update-trie-to-stacktrie
branch
from
August 1, 2023 04:18
25f9c44
to
260f47e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update deriveSha function for stacktrie. DeriveSha creates the tree hashes of transactions, receipts, and withdrawals in a block header.