Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Non-breaking changes] Unify multiple keccakState interfaces #369

Closed
wants to merge 1 commit into from
Closed

[Non-breaking changes] Unify multiple keccakState interfaces #369

wants to merge 1 commit into from

Conversation

trinhdn2
Copy link

There are the same unexported keccakState interfaces across vm and trie package with the same definition:

type keccakState interface {
	hash.Hash
	Read([]byte) (int, error)
}

This PR unify and expose that interface in the crypto package.

Reference:

@trinhdn2 trinhdn2 changed the base branch from master to upgrade-core-develop July 16, 2023 12:44
@tungng98 tungng98 added the non-breaking Enhancement that doesn't need a hardfork label Jul 16, 2023
@tungng98 tungng98 deleted the branch BuildOnViction:upgrade-core-develop December 10, 2023 16:51
@tungng98 tungng98 closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-breaking Enhancement that doesn't need a hardfork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants