Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes in SimpleModel, SimpleReaction, Subsystem. New features added to Subsystems. #9

Merged
merged 35 commits into from
Feb 7, 2019

Conversation

ayush9pandey
Copy link
Contributor

Bug fixes to 0.1 version.

…anges to others. Also not working for species not in list of shared resources. Also setting size using system size in volume mode amounts
…e, and connect all working. Need to fix the volume mode and make it consistent all over.
…PTG_transport graph generate for multiple inputs
… led to bugs which need to be fixed. simulatevariableinputs bioscrape method improved, along with many other changes
…rking yet in the new framework for combinations inside a System
…and it has been removed from the code. tutorial.py is working but combineSubsystem is not. minor fixes needed
… modes. Volume mode also works perfectly, virtual mode works too. combine does not depend on share now. All valid SBML models generated in SBML l3v2.
…rting to latest SBML level and version (l3v2). IPTG transport example working with this commit
…attribute was used which is obsolete in SBML L3v2
…t, SBML Model inside, and make all the basic settings using a standard set of preassigned values. An important bug fix in createSimpleReaction in SimpleModel class, to allow for reactions which create or degrade a particular species into nothing (when product/reactant missing).
…iableInputs method modified and multiple bugs fixed. Accepts lists for compartments, plotting options in a single plot or a matrix using subplots (not yet working).
…heir concentrations. fixed minor bug in simulate variable inputs for compartment species in else loop set to species id, replaced now with blank string, so optional keywords arguments should work. also added **kwargs to this function argument
* modified SimpleReaction.py to fix bug for creating simple reaction with numbers in species names/ids

* bug in create unit definition in simple model fixed

* added gitignore to remove temp files to go to github repo, bug fixes in SimpleModel class
ayush-pandey and others added 5 commits February 6, 2019 17:04
* modified SimpleReaction.py to fix bug for creating simple reaction with numbers in species names/ids

* modified iptg transport circuit. Improved membrane model. simulateVariableInputs method modified and multiple bugs fixed. Accepts lists for compartments, plotting options in a single plot or a matrix using subplots (not yet working).

* added varying alhl and varying gfp dna plots to guide experiment on their concentrations. fixed minor bug in simulate variable inputs for compartment species in else loop set to species id, replaced now with blank string, so optional keywords arguments should work. also added **kwargs to this function argument

* iptg transport working with modifications to variable input simulations
…te unit tests so that further code developments have backward compatibility. IPTG transport example renamed to main_IPTG_transport for better visibility.
@ayush9pandey ayush9pandey self-assigned this Feb 7, 2019
@ayush9pandey ayush9pandey merged commit d821027 into BuildACell:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant