Example Images added

[zjuradoq]

I have added some images that I had when I ran through a similar protocol. The vial used were clear, different than proposed vials. We can update images after first tests are run.

[murrayrm]

For the protocol itself, it looks like your editor may have changed the newline style or something since it appears that every line has changed. Can you try updating so that we only see the actual changes to the file (should just be where you added figures).

Also, I suggest giving the images more descriptive filenames. Although long, something like txtl-liposome_water-in-oil_description.png. That will make it easier for editors of the protocol to find the figures if they want to change something.

Finally, when you reference the figure I would do it as a local reference (![title](file.png)) rather than reference a GitHub blob. That keeps the repository more "self-contained".

[murrayrm]

@zjuradoq Any updates on this PR? One alternative to the changes here would be to close this PR and create an issue that we could use to see the images and comment on them. Then we could put the ones that we like best into the repository (with descriptive file names, etc).

[zjuradoq]

Images have been updated. Titles are more descriptive.

[murrayrm]

@zjuradoq A couple of things to sort out:

• It looks like you deleted the contents of protocol-list.md (the listing of protocols that was in the repository)?

• It looks like we are still getting a complete "rewrite" of txtl-liposome_water-in-oil.md, probably because the line format has changed. This makes it hard to see what has actually changed.

• I note some inconsistency in filenames that it would be good to sort out: some files have a jpg suffix, others have a JPG (caps) suffice. We should probably be consistent. Also, I would suggest using all lower case for filenames, just so that we eliminate the ambiguity about how to capitalize.

[zjuradoq]

I did delete the protocol-list.md on my branch. I was having a hard time updating the file, everything said it was up to date so I wanted to reload it from the BAC repository to my own.

I will have to see why this line rewrite is happening, though could it be entering spaces between the lines. Thus shifting the lines itself are causing it to read as a change.

For the file names are you referring to what is in the [name] or the (name).

[murrayrm]

To recover protocol-list.md you will have to use git reset to grab a file from an earlier commit. This is a bit complicated and you may have to read up on it.

Filename examples:

• You added Adapt_BF.JPG but also Step1_ResuspendLipidFilm.jpg (.JPG versus .jpg). I would call the first one Adapt_BF.jpgfor consistency. There are a half dozen files that should be changed.

• This is more of a matter of style, but I would probably change all filenames to be lower case and use underscore to separate words (adapt_bf.jpg, step1_resuspend_lipid_film.jpg). But really up to you.