-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
19 build in rpc clientserver #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#19 first draft of a building RPC client into a system // created working findChannel function [ci-skip]
#19 more unit tests // RPC unit tests inserted // new package to help
#19 created skel for unit testing // updated validation // if statement added to amqp.connect
#19 making sure that they are created as part of the sanity checks, and also that they still can cause an issue if registered twice under the same scope.
#19 static return of "world" for now
#19 added unit test to ensure that "queueName" is supplied
#19 minor fix
#19 can't seem to figure out how to get this to work // will revisit // formating // fix unit tests // add additional validations
better publishing steps #19
#19 remove 'tsc' for running unit testing
#19 ok. so re-tooled the code so that the string in the client is sent back to the server in the same method // next step would be taking the client data and having the server process the function to process it.
#19 working! nuff said!
#19 trying to fix...
#19 trying to fix... x2
#19 trying to fix... x3
#19 trying to fix... x4
#19 also fixed some validation tests
#19 updated decorate as well to indicate that it can be "null" as will as a string or array of strings
to many open threads were being left open // documentation wiped BREAKING CHANGE: dropped node-amqp-connection-manager support
#19 updated unit tests and now types are working in IDE
#19 fixes issues related to when this is a package for ESM, CJS and the associated types, so they get filtered down // unit testing is also now working with "js" with a new npm dev dependency
Completed! 👍 |
Bugs5382
pushed a commit
that referenced
this pull request
Nov 17, 2023
# 1.0.0 (2023-11-17) ### Bug Fixes * fix ci for release ([5f6982a](5f6982a)) * 19 build in rpc clientserver (#20) ([fc03bd1](fc03bd1)), closes [#20](#20) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) [#19](#19) ### Features * added .idea to gitignore ([4a7ca5b](4a7ca5b)) * fastify namespace issue ([5d12ca1](5d12ca1)) * formatting, update README.md ([97d06ff](97d06ff)) * initial code structure ([bb6c46b](bb6c46b)) * major code revamp ([426d10a](426d10a)) * npm install works ([bd7fac3](bd7fac3)) * set to version 0.0.0 for now ([a330c71](a330c71)) * updated main methods ([a05a897](a05a897)) ### BREAKING CHANGES * dropped node-amqp-connection-manager support * feature: typedoc generation added * new style
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.