Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to ensure date sorting works, and you can't bulk import dates in an invalid format. #15358

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Jan 13, 2025

Description

This PR makes sure that date-only fields sort correctly by adding tests, and it makes sure that bulk importing rows cannot introduce invalid data into datetime fields.

Launchcontrol

  • Bulk importing rows (e.g. from a CSV) now requires dates to be formatted in a strict way, e.g. date-times should be YYYY-MM-DDTHH:MM:SSZ, date-only should be YYYY-MM-DD, and time-only should be HH:MM:SS.

Copy link

linear bot commented Jan 13, 2025

Copy link

qa-wolf bot commented Jan 13, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/m labels Jan 13, 2025
@samwho samwho changed the title Budi 8960 issue sorting dates when using mmddyyyy Add tests to ensure date sorting works, and you can't bulk import dates in an invalid format. Jan 14, 2025
@samwho samwho marked this pull request as ready for review January 14, 2025 14:16
@samwho samwho requested a review from a team as a code owner January 14, 2025 14:16
@samwho samwho requested review from adrinr and removed request for a team January 14, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
firestorm Data/Infra/Revenue Team size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant