Allow use of AI fields in view calculations. #15325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
…allow-ai-column-to-be-used-in-view-calculations
…mment for the next person to stumble on this.
…allow-ai-column-to-be-used-in-view-calculations
adrinr
reviewed
Jan 9, 2025
| @@ -123,7 +123,7 @@ export interface AIFieldMetadata extends BaseFieldSchema { | |||
| operation: AIOperationEnum | |||
| columns?: string[] | |||
| column?: string | |||
| categories?: string[] | |||
| categories?: string | |||
There was a problem hiding this comment.
Why this change? Is this a comma separated string or something like this, now?
There was a problem hiding this comment.
It has always been comma separated. It being a string array on the type was a mistake.
adrinr
approved these changes
Jan 9, 2025
…allow-ai-column-to-be-used-in-view-calculations
samwho
deleted the
budi-8833-allow-ai-column-to-be-used-in-view-calculations
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows you to group by AI field types in calculation views.
In the process of working on this, I noticed we're calling out to the LLM twice when saving a row, so I've removed the duplicate work.
Companion pro PR: https://github.com/Budibase/budibase-pro/pull/350/files
Addresses
Launchcontrol