Typing frontend-core fetch apis #15295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
force-pushed
the
typing/fetch-apis
branch
from
c7acad4 to
775ecf8
Compare
adrinr
commented
Jan 8, 2025
| @@ -116,8 +115,11 @@ | |||
| } | |||
| }) | |||
| $: fields = bindings | |||
| .filter(x => arrayTypes.includes(x.fieldSchema?.type)) | |||
There was a problem hiding this comment.
This was causing the attachments and array fields to not be displayed properly on the dataprovider selector
adrinr
requested review from
mike12345567,
aptkingston and
samwho
and removed request for
a team and
mike12345567
mike12345567
reviewed
Jan 8, 2025
mike12345567
reviewed
Jan 8, 2025
packages/frontend-core/src/components/grid/stores/datasource.ts
Outdated
Show resolved
Hide resolved
mike12345567
reviewed
Jan 8, 2025
mike12345567
reviewed
Jan 8, 2025
adrinr
force-pushed
the
typing/fetch-apis
branch
from
8c74a4b to
0784a95
Compare
mike12345567
approved these changes
Jan 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Typing all the fetch classes from frontend-core. These conversions still contain some anys and some code could be simplified and cleaned (specially around nulls).
As this is a quite critical change, the approach was to modify as little as possible. Once merged in master, we can tackle case by case, improving the quality of these classes if required.