Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API typing fixes #15171

Merged
merged 1 commit into from
Dec 12, 2024
Merged

API typing fixes #15171

merged 1 commit into from
Dec 12, 2024

Conversation

mike12345567
Copy link
Collaborator

Description

Fixing some type issue found during the frontend-core updates.

Thanks to @aptkingston for finding these.

@mike12345567 mike12345567 self-assigned this Dec 12, 2024
@mike12345567 mike12345567 requested a review from a team as a code owner December 12, 2024 16:01
@mike12345567 mike12345567 requested review from adrinr and removed request for a team December 12, 2024 16:01
Copy link

qa-wolf bot commented Dec 12, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/xs labels Dec 12, 2024
Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@mike12345567 mike12345567 merged commit cf98669 into master Dec 12, 2024
20 checks passed
@mike12345567 mike12345567 deleted the fix/type-fixes branch December 12, 2024 16:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants