Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint #15130

Merged
merged 10 commits into from
Dec 9, 2024
Merged

Update eslint #15130

merged 10 commits into from
Dec 9, 2024

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Dec 5, 2024

Description

Upgrades all of our eslint-related dependencies, as well as updating us to the new eslint config format.

Unfortunately I wasn't able to get eslint-plugin-import working in this new world. I would appreciate someone else taking a stab at it, it would be a shame to use it. For now, I've just gotten things working without it.

Pro PR: https://github.com/Budibase/budibase-pro/pull/344

@samwho samwho requested a review from a team as a code owner December 5, 2024 18:16
@samwho samwho requested review from mike12345567 and removed request for a team December 5, 2024 18:16
Copy link

qa-wolf bot commented Dec 5, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@samwho samwho requested a review from adrinr December 5, 2024 18:16
@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/m labels Dec 5, 2024
Base automatically changed from typescript-5.7 to master December 5, 2024 18:22
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good to get closer to recommended!

@samwho samwho enabled auto-merge December 9, 2024 17:20
@samwho samwho merged commit b960b09 into master Dec 9, 2024
19 checks passed
@samwho samwho deleted the update-eslint branch December 9, 2024 17:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants