Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log SQS connection errors, and retry connection a few times before giving up. #14969

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Nov 5, 2024

Description

We've had a report from a customer using the single image that the app process isn't making a successful connection to SQS on boot. In this PR I'm logging out the reason that might be, as well as baking in some retries to product against network flakiness.

@samwho samwho requested a review from mike12345567 November 5, 2024 15:36
@samwho samwho requested a review from a team as a code owner November 5, 2024 15:36
Copy link

qa-wolf bot commented Nov 5, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/s labels Nov 5, 2024
@samwho samwho enabled auto-merge November 5, 2024 15:39
@samwho samwho merged commit 33f535c into master Nov 6, 2024
13 checks passed
@samwho samwho deleted the sqs-test-fixes branch November 6, 2024 12:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants