Support setting multiple many to many relationships between two tables #14966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
…ips-between-two-tables
aptkingston
approved these changes
Nov 5, 2024
adrinr
deleted the
BUDI-8746/multiple-many-to-many-relationships-between-two-tables
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently support multiple many-to-many between the same tables, but the the frontend does not properly support it. This PR is updating the "define relationship" modal to support this config, moving the error message to a clearer field.
Also, adding an extra check to make sure that the same column is not used as both foreign keys on a join table, and fixing the initial type load on existing relationships.
Addresses
Screenshots
Current settings
Can add new relationships between people -> tasks
Cannot reuse the same through and foreign keys (whatever the order)
Cannot set both foreign keys to the same column
Launchcontrol
Support configuring multiple many-to-many between the same tables