Data section toolbar standardisation #14888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
deanhannigan
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
LGTM! Awesome update @aptkingston! Really refines the UX in the data section. Only one issue found during testing around the import popover not locking down the types, but I've already gone through that with you. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates all the controls in the data section toolbar to use the same component - detail popovers. Currently there are 4 different components used for the various controls - popovers, detail popovers, modals and drawers. Having a single experience for all controls is a much nicer experience for the user.
Functionality wise, the only change is to the export button. Since it's only available on tables (where filters cannot be applied) I could massively reduce the complexity of that component. Now you can only export all data, or the selected rows.
Before and after
Import button
Export button
Filter button
Sort button
Size button
Columns button
View calculations button