Remove row actions when unfetching tables #14860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
commented
Oct 24, 2024
| t => !Object.keys(tables).includes(t) | ||
| ) | ||
| for (const table of tablesToRemove) { | ||
| await sdk.rowActions.deleteAll(oldTables[table]._id!) |
There was a problem hiding this comment.
I don't like adding the row action stuff mixed with the datasource, but this is the only way to do it without redesigning how this currently works..
samwho
approved these changes
Oct 24, 2024
Base automatically changed from
BUDI-8774/row-actions-dont-get-deleted-when-removing-a-datasource
to
v3-ui
October 24, 2024 16:04
adrinr
deleted the
BUDI-8774/delete-row-actions-when-unfetching-tables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #14859, we might have orphan row actions when some tables are "unfetched". This PR ensures that row actions are removed when a table has been indirectly removed.