Row action name cleanup #14849
Merged
Row action name cleanup #14849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
commented
Oct 23, 2024
| @@ -68,26 +69,6 @@ export async function create( | |||
| ctx.status = 201 | |||
| } | |||
|
|
|||
| export async function update( | |||
There was a problem hiding this comment.
This logic has not been moved to the automation screen, so this is not needed anymore
adrinr
commented
Oct 23, 2024
| const table = await getTable(ctx) | ||
| const tableId = table._id! | ||
| const { actionId } = ctx.params | ||
|
|
||
| const action = await sdk.rowActions.setTablePermission(tableId, actionId) | ||
| ctx.body = { | ||
| tableId, |
There was a problem hiding this comment.
This data is not actually required, and it would require fetching the automation names. Instead of adding the extra call, we can just simplify the responses
adrinr
requested review from
samwho,
mike12345567,
aptkingston and
a team
and removed request for
a team
adrinr
changed the title
aptkingston
approved these changes
Oct 23, 2024
adrinr
deleted the
BUDI-8770/row-action-automation-names-are-not-updated-in-automation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On the initial design of row actions, the crud of these (specially editions and deletions) were done in the data section. With the latest designs, these are managed in the automation section, so there is quite a lot of code that can be simplified to achieve this.
Main changes:
Addresses