Default user columns to current user for templates #14839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
force-pushed
the
BUDI-8766/default-user-columns-to-current-user-for-templates
branch
from
5f755c6 to
cb5082a
Compare
Merged
samwho
approved these changes
Oct 22, 2024
adrinr
commented
Oct 22, 2024
| @@ -279,6 +276,10 @@ async function performAppCreate(ctx: UserCtx<CreateAppRequest, App>) { | |||
| const instance = await createInstance(appId, instanceConfig) | |||
| const db = context.getAppDB() | |||
|
|
|||
| if (instanceConfig.useTemplate && !instanceConfig.file) { | |||
| await updateUserColumns(appId, db, ctx.user._id!) | |||
There was a problem hiding this comment.
This is the actual work that does the required job, the rest is just typing and cleaning
samwho
approved these changes
Oct 22, 2024
adrinr
deleted the
BUDI-8766/default-user-columns-to-current-user-for-templates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the new templates containing user columns, we need a way to set valid values for it. Otherwise, the data will be trimmed on the way out, causing some unexpected behaviours on the template.
This PR ensures that when a new app comes from a template, the user column data will be defaulted to the creator of the app.
Also, updating multiple interface and typings that were not correct and misleading
Screenshoots
Using the following data as a template
Before, using that template, the user column was empty
After, the data gets populated with the user creator