Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update tj-actions/changed-files action to v40 [security] - autoclosed #139

Closed
wants to merge 1 commit into from
Closed

chore(deps): update tj-actions/changed-files action to v40 [security] - autoclosed #139

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 2, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
tj-actions/changed-files action major v39 -> v40

GitHub Vulnerability Alerts

CVE-2023-51664

Summary

The tj-actions/changed-files workflow allows for command injection in changed filenames, allowing an attacker to execute arbitrary code and potentially leak secrets.

Details

The changed-files action returns a list of files changed in a commit or pull request which provides an escape_json input enabled by default, only escapes " for JSON values.

This could potentially allow filenames that contain special characters such as ; and ` (backtick) which can be used by an attacker to take over the GitHub Runner if the output value is used in a raw fashion (thus being directly replaced before execution) inside a run block. By running custom commands an attacker may be able to steal secrets such as GITHUB_TOKEN if triggered on other events than pull_request. For example on push.

Proof of Concept

  1. Submit a pull request to a repository with a new file injecting a command. For example $(whoami).txt which is a valid filename.
  2. Upon approval of the workflow (triggered by the pull request), the action will get executed and the malicious pull request filename will flow into the List all changed files step below.
      - name: List all changed files
        run: |
          for file in $; do
            echo "$file was changed"
          done

Example output:

##[group]Run for file in $(whoami).txt; do
    for file in $(whoami).txt; do
        echo "$file was changed"
    done
shell: /usr/bin/bash -e {0}

##[endgroup]
runner.txt was changed

Impact

This issue may lead to arbitrary command execution in the GitHub Runner.

Resolution

  • A new safe_output input would be enabled by default and return filename paths escaping special characters like ;, ` (backtick), $, (), etc for bash environments.

  • A safe recommendation of using environment variables to store unsafe outputs.

- name: List all changed files
  env:
    ALL_CHANGED_FILES: $
  run: |
    for file in "$ALL_CHANGED_FILES"; do
      echo "$file was changed"
    done

Resources

Release Notes

tj-actions/changed-files (tj-actions/changed-files)

v40

Compare Source

Changes in v40.2.3
What's Changed

Full Changelog: tj-actions/changed-files@v40...v40.2.3

Changes in v40.2.2
What's Changed

Full Changelog: tj-actions/changed-files@v40...v40.2.2

Changes in v40.2.1
What's Changed

Full Changelog: tj-actions/changed-files@v40...v40.2.1

Changes in v40.2.0
What's Changed

Full Changelog: tj-actions/changed-files@v40...v40.2.0

Changes in v40.1.1
What's Changed

Full Changelog: tj-actions/changed-files@v40...v40.1.1

Changes in v40.1.0
What's Changed

Full Changelog: tj-actions/changed-files@v40...v40.1.0

Changes in v40.0.2
What's Changed

Full Changelog: tj-actions/changed-files@v40...v40.0.2

Changes in v40.0.1
What's Changed

Full Changelog: tj-actions/changed-files@v40...v40.0.1

Changes in v40.0.0
🔥 🔥 Breaking Change 🔥 🔥
  • Directory patterns now require explicit specification of the globstar pattern to match all sub paths.
...
      - name: Get specific changed files
        id: changed-files-specific
        uses: tj-actions/changed-files@v40
        with:
          files: |
-            dir
+            dir/**
What's Changed

Full Changelog: tj-actions/changed-files@v39...v40.0.0

Configuration

📅 Schedule: Branch creation - "" in timezone America/New_York, Automerge - "after 10pm every weekday,before 5am every weekday,every weekend" in timezone America/New_York.

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the actions label Jan 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024

Hadolint: skipped

undefined

@codecov Codecov
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dafbec0) 9.06% compared to head (6ea2a7b) 8.99%.

Additional details and impacted files 
@@            Coverage Diff            @@
##           master    #139      +/-   ##
=========================================
- Coverage    9.06%   8.99%   -0.07%     
=========================================
  Files          52      52              
  Lines        4602    4602              
  Branches       75      75              
=========================================
- Hits          417     414       -3     
- Misses       4144    4147       +3     
  Partials       41      41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot changed the title chore(deps): update tj-actions/changed-files action to v40 [security] chore(deps): update tj-actions/changed-files action to v40 [security] - autoclosed Jan 8, 2024
@renovate renovate bot deleted the dep/github-tags-tj-actions/changed-files-vulnerability branch January 8, 2024 12:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@renovate-approve renovate-approve[bot] renovate-approve[bot] approved these changes

Assignees
No one assigned
Labels
actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BrycensRanch