Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic accessors macro #61

Merged
merged 24 commits into from
May 31, 2023
Merged

Automatic accessors macro #61

merged 24 commits into from
May 31, 2023

Conversation

Artemka374
Copy link
Contributor

@Artemka374 Artemka374 commented May 16, 2023 •
edited
Loading

Create a macro for simple automated getter creation

coreggon11
coreggon11 reviewed May 17, 2023
View reviewed changes
coreggon11
coreggon11 suggested changes May 17, 2023
View reviewed changes
coreggon11
coreggon11 reviewed May 17, 2023
View reviewed changes
coreggon11
coreggon11 reviewed May 17, 2023
View reviewed changes
Copy link
Contributor

@coreggon11 coreggon11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pls see my comments

@Artemka374 Artemka374 changed the title Automatic getters macro Automatic accessors macro May 19, 2023
@grandima
Copy link
Contributor

grandima commented May 21, 2023 •
edited
Loading

I can handle all the comments. But before that, can you fix:

cargo test --features e2e-tests --release
doesn't build for folder examples/psp22

@coreggon11
Copy link
Contributor

I realised one more thing) Macro should check if the annotated field is Mapping and in that case create setter(K: key, V: value) or getter get(K: key) -> V

@grandima grandima mentioned this pull request May 23, 2023
Merged
varex83
varex83 previously approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@varex83 varex83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, but comments :D

@varex83 varex83 requested a review from coreggon11 May 25, 2023 12:51
varex83
varex83 previously approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@varex83 varex83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

coreggon11
coreggon11 reviewed May 26, 2023
View reviewed changes
Copy link
Contributor

@coreggon11 coreggon11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comments pls

@Artemka374 Artemka374 requested a review from coreggon11 May 31, 2023 08:19
coreggon11
coreggon11 reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@coreggon11 coreggon11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm missing some UI tests for the macro

@coreggon11 coreggon11 self-requested a review May 31, 2023 10:39
@Artemka374 Artemka374 merged commit 24a5ed3 into main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreggon11 coreggon11 coreggon11 approved these changes

@varex83 varex83 varex83 left review comments

@grandima grandima Awaiting requested review from grandima

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Artemka374 @grandima @coreggon11 @varex83