Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix native Buffer allocation #7

Merged
merged 2 commits into from
Feb 11, 2018
Merged

Fix native Buffer allocation #7

merged 2 commits into from
Feb 11, 2018

Conversation

billinghamj
Copy link
Contributor

Resolves #6

@coveralls
Copy link

coveralls commented Feb 10, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 9e416b3 on billinghamj:patch-1 into 19c8469 on Bruce17:master.

@billinghamj
Copy link
Contributor Author

I don't wish to be rude, but please: if you don't know what you're doing, do not release crypto libraries.

Who knows how many people now have fundamentally broken credential comparisons, who may never even update to a fixed version of this package?

Please deprecate the old version also: https://docs.npmjs.com/cli/deprecate

@billinghamj billinghamj mentioned this pull request Feb 10, 2018
Closed
@Bruce17 Bruce17 merged commit ba88084 into Bruce17:master Feb 11, 2018
@billinghamj billinghamj deleted the patch-1 branch February 15, 2018 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@billinghamj @coveralls @Bruce17