This repository has been archived by the owner on Oct 13, 2018. It is now read-only.
Added conditional get support for client script middleware #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maoueh
changed the title
* The client script is now served conditionnaly based on the request headers. This means that if the browser sends a conditional request and the current body is fresh, we send a not modified response. Otherwise, we send the request as usual.
maoueh
force-pushed
the
feature-cacheable-client-script-serve
branch
from
d26bc2c to
20582f3
Compare
|
thanks @maoueh - one more thing while we're on this topic, why not also send a gzipped response? |
|
I don't have any problem with that. Can I take this as a go :)? Plan would be to check if browser support it (via the |
maoueh
changed the title
|
Yep, perfect |
|
|
||
| var script = path.resolve(__dirname + "/dist/index.min.js"); | ||
| var minifiedScript = path.resolve(__dirname + "/dist/index.min.js"); |
There was a problem hiding this comment.
For Windows support:
var minifiedScript = path.join(__dirname, "dist/index.min.js");
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client script is now served conditionally based on the request headers. This means that if the browser sends a conditional request and the current body is fresh, we send a not modified response. Otherwise, we send the request as usual.
Note that I get inspiration from the send package (which in fact I tried to use in my first draft). But most of the stuff we need are in private APIs but we might think about re-using them anyway.
This is complete from my point of view, simply missing your input.