Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global variables for each selection #285

Merged
merged 4 commits into from
Feb 3, 2017

Conversation

kreczko
Copy link
Member

@kreczko kreczko commented Feb 1, 2017

As part of the efforts to replace AS, I've added the global variabels to the ntuples.
This is done per 'object family' such that we have the variables per selection.

Of course, the global vars are only valid if you also check if the event passes the appropriate selection (e.g. HT is well defined for 1 jet).

Test ntuple can be found on soolin in /storage/phxlk/eventUserData.root

@mention-bot
Copy link

@kreczko, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jjacob, @EmyrClement and @senkin to be potential reviewers.

Copy link
Contributor

@EmyrClement EmyrClement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the one comment, what is meant by "This is done per 'object family' such that we have the variables per selection." ?

*m_bl = utils::m_bl(bjets, lepton);
*angle_bl = utils::angle_bl(bjets, lepton);
}
*st = utils::st(jets, met, lepton);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically ST is defined if there are no leptons (or more than one lepton). However I guess our lowest baseline selection is at least one lepton, so I don't mind is this isn't changed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with the definition in our slides which always includes the lepton pT. I understand that there are more than one :).

@kreczko
Copy link
Member Author

kreczko commented Feb 3, 2017

Yeah, on second thought, that line is not clear. What I mean by object family is a set of jet, bjet, electron & muon inputs which is currently tied to the selections.

However, you can also change the inputs to create the variables for JEC up/down!
Well, at least once the code for that becomes available. I did not want to do too much at once.

@EmyrClement EmyrClement merged commit 60342f4 into BristolTopGroup:master Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants