Refactor tier price table rendering and sorting logic #89
Conversation
This commit refactors the JavaScript code responsible for rendering and sorting the tier price table. It improves the readability and maintainability of the code by introducing better variable names and using modern JavaScript syntax. The changes include: - Replacing jQuery selectors with native JavaScript methods The changes also fix a bug where the tier price table was not properly sorted when the page was loaded.
src/Traits/TierPriceableTrait.php
Outdated
| * @ORM\OneToMany(targetEntity="Brille24\SyliusTierPricePlugin\Entity\TierPrice", mappedBy="productVariant", cascade={"persist", "remove"}, orphanRemoval=true) | ||
| * @ORM\OrderBy({"customerGroup" = "ASC", "qty" = "ASC"}) | ||
| */ |
There was a problem hiding this comment.
Why did you migrate this back to annotations?
| @@ -17,9 +17,6 @@ | |||
| use Doctrine\DBAL\Schema\Schema; | |||
| use Doctrine\Migrations\AbstractMigration; | |||
|
|
|||
| /** | |||
| * Auto-generated Migration: Please modify to your needs! | |||
| */ | |||
| final class Version20201014111513 extends AbstractMigration | |||
There was a problem hiding this comment.
If you're already at it remove the entire migration directory. They should be run in the project installing it.
|
Oh no, I’m sorry. The first commit (4c341b4) was the one I intended to submit, but 9752156 contains changes I need for my personal project, which I didn’t mean to include. Sorry about that, this is my first time contributing to a GitHub project. I have made a new commit, and now the only remaining changes are the conversion of the file from jQuery to native JavaScript, and the import of itemCollectionRender.js in _tierprice.html.twig since the Twig file wasn’t detecting the JavaScript file properly. |
|
Thank you again for your contribution, I have merged and tagged it now. If you require 3.0.1 in your project of this plugin you'll get your fixes natively. 🎉 |
The changes fix an Issue where the tier price table was not properly sorted when the page was loaded. :