Disable the media-query-no-invalid rule since it conflicts with JavaScript. #25

dbatiste · 2023-07-10T19:05:28Z

This PR disables the media-query-no-invalid that was added in stylelint-config-recommended@13.

The rule causes the following (reasonable example from copycat) scenario to fail:

@media (max-width: ${MEDIA_BREAKPOINT}px) {
	.d2l-heading-1 {
		margin: 1.2rem 0;
	}
}

…cript variables.

dlockhart

Seems fine to disable it. This is where if we had alternative rules for Lit vs. vanilla CSS it might make sense to have some deviation, but not worth introducing that here.

ghost · 2023-07-10T20:10:19Z

🎉 This PR is included in version 0.8.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Disable the media-query-no-invalid rule since it conflicts with JavaS…

ab55cba

…cript variables.

dbatiste requested a review from a team as a code owner July 10, 2023 19:05

svanherk approved these changes Jul 10, 2023

View reviewed changes

dlockhart approved these changes Jul 10, 2023

View reviewed changes

dbatiste merged commit 85771af into main Jul 10, 2023

dbatiste deleted the dbatiste/disable-media-query-no-invalid branch July 10, 2023 20:09

ghost added the released label Jul 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable the media-query-no-invalid rule since it conflicts with JavaScript. #25

Disable the media-query-no-invalid rule since it conflicts with JavaScript. #25

dbatiste commented Jul 10, 2023 •

edited

Loading

dlockhart left a comment

ghost commented Jul 10, 2023

Disable the media-query-no-invalid rule since it conflicts with JavaScript. #25

Disable the media-query-no-invalid rule since it conflicts with JavaScript. #25

Conversation

dbatiste commented Jul 10, 2023 • edited Loading

dlockhart left a comment

Choose a reason for hiding this comment

ghost commented Jul 10, 2023

dbatiste commented Jul 10, 2023 •

edited

Loading