Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the backdrop while displaying the popover as mobile tray #5299

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

dbatiste
Copy link
Contributor

@dbatiste dbatiste commented Jan 9, 2025

GAUD-6563

This PR adds the backdrop to the Popover mobile tray.

inline-start
image

inline-end
image

block-end
image

@dbatiste dbatiste requested a review from a team as a code owner January 9, 2025 17:05
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-5299/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

components/popover/popover-mixin.js Outdated Show resolved Hide resolved
components/popover/popover-mixin.js Outdated Show resolved Hide resolved
dbatiste and others added 2 commits January 9, 2025 19:37
Co-authored-by: Dave Lockhart <dlockhart@users.noreply.github.com>
Co-authored-by: Dave Lockhart <dlockhart@users.noreply.github.com>
@dbatiste dbatiste merged commit d50652b into main Jan 10, 2025
6 checks passed
@dbatiste dbatiste deleted the dbatiste/popover-tray-backdrop branch January 10, 2025 01:05
Copy link

🎉 This PR is included in version 3.79.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants