Implement a sparse outstanding index for the dynamo db outbox [v9] #3295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhickie
requested review from
iancooper,
holytshirt,
DevJonny and
preardon
as code owners
iancooper
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #3293 by updating the key of the
Outstandingindex so that it becomes a sparse index and is only populated with messages that are yet to be dispatched.It does this by adding a new attribute to the record,
OutstandingCreatedTime, which is identical toCreatedTimebut it only populated if the message is yet to be dispatched. Once a message is marked as dispatched,OutstandingCreatedTimeis set to null, thereby removing the attribute from the record.Note that this is a breaking change to the table structure - any outboxes created prior to the introduction of this PR will not work and will result in exceptions until a migration to the new outbox structure has taken place.