Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ASB Transport #3229

Merged
merged 11 commits into from
Aug 26, 2024
Merged

Refactor ASB Transport #3229

merged 11 commits into from
Aug 26, 2024

Conversation

preardon
Copy link
Member

@preardon preardon commented Jul 23, 2024 •
edited
Loading

@iancooper iancooper added 2 - In Progress feature request v10 Allocal to a v10 release .NET Pull requests that update .net code labels Jul 24, 2024
Jonny-Freemarket
Jonny-Freemarket approved these changes Jul 29, 2024
View reviewed changes
Copy link

@Jonny-Freemarket Jonny-Freemarket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some minor questions about some logging.

DevJonny
DevJonny approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@DevJonny DevJonny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions in the queue consumer logging.

src/Paramore.Brighter.MessagingGateway.AzureServiceBus/AzureServiceBusQueueConsumer.cs Outdated Show resolved Hide resolved
src/Paramore.Brighter.MessagingGateway.AzureServiceBus/AzureServiceBusQueueConsumer.cs Outdated Show resolved Hide resolved
@preardon preardon marked this pull request as ready for review August 25, 2024 08:59
DevJonny
DevJonny approved these changes Aug 25, 2024
View reviewed changes
Copy link
Contributor

@DevJonny DevJonny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@preardon preardon merged commit 8fe55a7 into master Aug 26, 2024
16 of 19 checks passed
@preardon preardon deleted the refactorASB branch August 26, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DevJonny DevJonny DevJonny approved these changes

@Jonny-Freemarket Jonny-Freemarket Jonny-Freemarket approved these changes

@iancooper iancooper Awaiting requested review from iancooper iancooper is a code owner

@holytshirt holytshirt Awaiting requested review from holytshirt holytshirt is a code owner

Assignees
No one assigned
Labels
2 - In Progress feature request .NET Pull requests that update .net code v10 Allocal to a v10 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@preardon @DevJonny @Jonny-Freemarket @iancooper