Set correct span status for Send and SendAsync #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icitly on exception
easyfy-fredrik
requested review from
iancooper,
holytshirt and
DevJonny
as code owners
|
|
|
Thanks @easyfy-fredrik I am going to pull in @preardon to review, as he wrote our original telemetry support |
iancooper
approved these changes
Dec 4, 2022
|
@easyfy-fredrik We have a couple of other fixes in the pipe, if they are there in the next 24 hours I will fold into a release, otherwise I will get this out then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenTelemetry instrumentation
Span status (Error/OK) gets flipped for Send() and SendAsync() while being correct for Publish() and PublishAsync().
EndSpan() has a success parameter which sets the span status to Error if true which is a bit confusing.
This change sets Error status directly on exception and assumes success if no other status is set, this should fix the flipped status and remove the need for the success parameter.