Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bouncycastle to build on non-Oracle JDKs #769

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Allow bouncycastle to build on non-Oracle JDKs #769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jlink {
imageDir = file(JLINK_DIR)
imageZip = file(JLINK_DIR + ".zip")
addOptions '--add-modules', MODULES_TO_ADD, '--strip-debug', '--compress', '2',
'--no-header-files', '--no-man-pages'
'--no-header-files', '--no-man-pages', '--ignore-signing-information'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a downside / danger to adding this?

If not, should we merge into 1.4.0 as well?

If so, we should flag this PR in #767 as another thing we'd need to eventually get into 1.4.0.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will definitely flag this in #767 to address before merging to 1.4.0

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do need to. I created a draft PR for discussion here: #770

mergedModule {
requires "java.xml"
}
Expand Down