Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combo text box / check box input for maxSkippedRanksAllowed and maxRankingsAllowed #498

Closed
HEdingfield opened this issue Aug 17, 2020 · 1 comment
Assignees
Milestone

Comments

@HEdingfield
Copy link
Contributor

  • maxRankingsAllowed should default to having the "Maximum" check box selected

  • maxSkippedRanksAllowed should default to having the "Unlimited" check box unselected (and 1 in text box)

  • Checking either check box should disable and clear the text box

  • More to consider from @chughes297:

    I vaguely remember discussing a fill-in + checkbox option with Lynn but don't remember where we wound up. The more I think about number of rankings the more I think we should require people to put in the number of rankings, because to some places "max" would be all candidates + a write-in (or write-ins) while in others "max" may mean just all candidates. We could clear that up with instructions/hints/etc but it seems simpler to me to just ask people how many rankings are permitted in the contest and require numeric entry.

    I'm neutral on splitting up the skipped rankings question, it's just a matter of asking the questions in the right order . Probably would first ask about whether voters can skip as many rankings as they want, then if the box is left unchecked have them indicate how many rankings a voter can skip? I'm having a hard time thinking of how to phrase these questions... Maybe "Can voters skip unlimited rankings in a row and still have later rankings count" for checkbox and "How many consecutive skipped ranks are allowed" for the entry field?

@HEdingfield HEdingfield added this to the v1.2 milestone Aug 17, 2020
@HEdingfield HEdingfield self-assigned this Aug 17, 2020
HEdingfield added a commit that referenced this issue Sep 28, 2020
…ieldMaxRankingsAllowed` to substitute "unlimited" and "max" values in, respectively (fixes #498).
HEdingfield added a commit that referenced this issue Sep 28, 2020
… and `maxRankingsAllowed` (#515)

* Adds check boxes next to `textFieldMaxSkippedRanksAllowed` and `textFieldMaxRankingsAllowed` to substitute "unlimited" and "max" values in, respectively (fixes #498).
* Refactors `choiceWinnerElectionMode.setOnAction` logic.
@HEdingfield
Copy link
Contributor Author

Closed with #515.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant