Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix noinspection unchecked for excluded CheckBox in GuiConfigController #304

Closed
tarheel opened this issue Jun 23, 2019 · 4 comments
Closed

fix noinspection unchecked for excluded CheckBox in GuiConfigController #304

tarheel opened this issue Jun 23, 2019 · 4 comments
Assignees
@HEdingfield
Labels
1.2.0 deliverable code cleanup
Milestone
v1.2

Comments

@tarheel
Copy link
Contributor

tarheel commented Jun 23, 2019

No description provided.

@tarheel tarheel added this to the v 1.1 Future milestone Jun 23, 2019
@tarheel tarheel mentioned this issue Jun 23, 2019
Merged
@HEdingfield
Copy link
Contributor

This applies to GuiConfigController.initialize():

// noinspection unchecked
return new SimpleObjectProperty(checkBox);

@HEdingfield
Copy link
Contributor

I believe this was also resolved with #462.

@HEdingfield
Copy link
Contributor

HEdingfield commented Jul 29, 2020 •
edited
Loading

The "fix" in #462 here resolved the warning, but it also broke checkboxes in the Candidates table (now they only appear as "true" or "false" and it's uneditable). Need to roll this back.

@HEdingfield HEdingfield reopened this Jul 29, 2020
@HEdingfield HEdingfield modified the milestones: v1.x Future, v1.2 Aug 5, 2020
@HEdingfield HEdingfield mentioned this issue Aug 9, 2020
Merged
HEdingfield added a commit that referenced this issue Aug 9, 2020
@HEdingfield
Fixes candidate excluded checkbox in table
bc4b569 
Rolls back part of #462 because, although it resolved the warning mentioned in #304, it also broke checkboxes in the Candidates table (so they only appear as "true" or "false" and are uneditable).
@HEdingfield
Copy link
Contributor

Duplicate of #280.

@HEdingfield HEdingfield mentioned this issue Aug 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HEdingfield HEdingfield

Labels
1.2.0 deliverable code cleanup
Projects
None yet
Milestone
v1.2
Development

No branches or pull requests
2 participants
@tarheel @HEdingfield