updated test suits #298
Merged
updated test suits #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add link to demo in readme
kavitharaju
requested changes
Feb 19, 2025
rust-usfm-parser/tests/test_utils.rs
Outdated
Comment on lines
32
to
49
| impl USFMMarker { | ||
| fn get_markers(&self) -> Vec<&'static str> { | ||
| match self { | ||
| USFMMarker::BookHeaders => vec!["ide", "usfm", "h", "toc", "toca"], | ||
| USFMMarker::Titles => vec![ | ||
| "mt", "mte", "cl", "cd", "ms", "mr", "s", "sr", "r", "d", "sp", "sd", | ||
| ], | ||
| USFMMarker::Comments => vec!["sts", "rem", "lit", "restore"], | ||
| USFMMarker::Paragraphs => vec!["p", "m", "po", "pr", "cls", "pmo", "pm", "pmc"], | ||
| USFMMarker::Characters => vec![ | ||
| "add", "bk", "dc", "ior", "iqt", "k", "litl", "nd", "ord", "pn", | ||
| ], | ||
| USFMMarker::Notes => vec!["f", "fe", "ef", "efe", "x", "ex"], | ||
| USFMMarker::StudyBible => vec!["esb", "cat"], | ||
| USFMMarker::BCV => vec!["id", "c", "v"], | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Why is this defined here? Is it part of testing logic or core logic?
There was a problem hiding this comment.
sorry mam, its part of the core logic ,i used it while implimenting the code for test case,forget to change .it doesnt have any function in the code .
rust-usfm-parser/tests/test_utils.rs
Outdated
Comment on lines
327
to
330
| // Test functions | ||
| #[cfg(test)] | ||
| mod tests { | ||
| use rust_usfm::usj_generator::usj_generator; |
There was a problem hiding this comment.
it would be good to keep tests in a separate file and keep only utility functions here. As we add more testing code it we help us maintain modularity.
There was a problem hiding this comment.
test_usj.rs would be good.
kavitharaju
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test suits added for
comparing with test suit samples
for testing usj output is valid
to test whether all markers in input are in output
and verified
currently 0 test cases are passed