Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update usx schema #207

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Update usx schema #207

merged 3 commits into from
Jun 30, 2023

Conversation

kavitharaju
Copy link
Collaborator

@kavitharaju kavitharaju commented Jun 30, 2023 •
edited
Loading

  • Pulled the latest RNG Grammar from usfm-bible/tcdocs
  • Testing again, the USX generation and validation
    • Removed the older list of doubtful USXs, including them also in the test now
    • 181 positive samples from testsuite have been used for test
    • Following is the results of testing, as of now. Planning to investigate the failures and make changes as required

Validating generated USX against the updated RNG grammar from usfm-bible/tcdocs

66 Failed 115 Passed

Validating USX samples in testsuite itself, against the RNG grammar

44 Failed 133 Passed (Martin's Stat is 159/258 Passing for him)

Comparing generated USX against USX samples in the testsuite

157 Failed 24 Passed 😄

@kavitharaju kavitharaju added test This has to do with testing. python-module labels Jun 30, 2023
@kavitharaju kavitharaju requested a review from joelthe1 June 30, 2023 03:45
@joelthe1 joelthe1 merged commit 1c52124 into Bridgeconn:version-3 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelthe1 joelthe1 Awaiting requested review from joelthe1

Assignees
No one assigned
Labels
python-module test This has to do with testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kavitharaju @joelthe1