Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout option #10

Merged
merged 1 commit into from
Sep 27, 2020
Merged

Add timeout option #10

merged 1 commit into from
Sep 27, 2020

Conversation

BrianMitchL
Copy link
Owner

  • Add timeout option, still defaults to 1000ms
  • Add new options Object syntax for passing in exclusions and timeouts
  • Deprecate the calculate function

If an impossible, or slow match is under way, the thread will be blocked until the timeout, or a match is found. Wrapping this in a Promise doesn't change this, so it's an unhelpful function.

This also deprecates the calculate function
@github-actions
Copy link

size-limit report

Path Size
dist/gift-exchange.cjs.production.min.js 1.03 KB (+5.59% 🔺)
dist/gift-exchange.esm.js 1.05 KB (+5.59% 🔺)
dist/gift-exchange.umd.production.min.js 1.03 KB (+5.4% 🔺)

@BrianMitchL BrianMitchL merged commit 127fb0f into master Sep 27, 2020
@BrianMitchL BrianMitchL deleted the custom-timeouts branch September 27, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant