Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: --dry-run command & verbose logging #139

Merged
merged 141 commits into from
Feb 14, 2025
Merged

Add: --dry-run command & verbose logging #139

merged 141 commits into from
Feb 14, 2025

Conversation

BrianHenryIE
Copy link
Owner

@BrianHenryIE BrianHenryIE commented Jan 15, 2025 •
edited
Loading

strauss --dry-run should print to console the changes that might be made, and not modify any files

This PR has added a FileSystem class and all file system operations will go through it, allowing a transparent cache of file modifications in a ReadOnlyFileSystem class, and also provides a nice place to protect against unintentional modification/deleting of files that are symlinked into a project.

TODO:

Info logging added:

  • load config
  • DependenciesEnumerator
  • FileEnumerator
  • FileCopyScanner
  • Copier
  • FileSymbolScanner
  • Prefixer
  • Licenser
  • Autoload
  • Cleanup

Debug logging added:

  • load config
  • DependenciesEnumerator
  • FileEnumerator
  • FileCopyScanner
  • Copier
  • FileSymbolScanner
  • Prefixer
  • Licenser
  • Autoload
  • Cleanup

CLI switches

  • --dry-run
  • --info display info messages
  • --debug display debug messages
  • --silent

@BrianHenryIE BrianHenryIE changed the title Add/dry run command Add: --dry-run command & verbose logging Jan 15, 2025
@BrianHenryIE
Update PrefixerConfigInterface.php
fc8f50f
@BrianHenryIE
Inject League\Flysystem\Filesystem
059c111
@BrianHenryIE
Remove File::getContents(); use FilesystemReader in `FileSymbolSc…
cd46130 
…anner`
@BrianHenryIE
Use FileSystem in DependenciesEnumerator
b39253f
@BrianHenryIE
Create ReadOnlyFileSystem extends Filesystem
fd3020d
@BrianHenryIE
Remove FileEnumerator::findFilesInDirectory() use flysystem
0cb259b
@BrianHenryIE
Mark test inadequate
2f53350
@BrianHenryIE
use League\Flysystem in Autoload
99bc8be
@BrianHenryIE
use BrianHenryIE\Strauss\Helpers\FileSystem;
169bc76
@BrianHenryIE
Update DependenciesCommand.php
6ba184b
@BrianHenryIE
trim DIRECTORY_SEPARATOR from both ends for match
034ba4c
@BrianHenryIE
Replace some is_dir() uses
c0c0a05
@BrianHenryIE
Replace file_exists()
5b469c7
@BrianHenryIE
Remoce is_dir() use from ComposerPackage
1aa29db
@BrianHenryIE
Remove is_dir() convenience in ProjectComposerPackage
ca76d96
@BrianHenryIE
Fix file/dir exists check
fb5dda2
@BrianHenryIE
I don't know
81b84e5
@BrianHenryIE
Speed up tests: Use Composer provide key to avoid unnecessary downl…
88ba516 
…oading
@BrianHenryIE
Extract IntegrationTestCase::markTestSkippedOnPhpVersion()
28d34ea
@BrianHenryIE
Update logging in Prefixer
08f1ecd
@BrianHenryIE
Log when case is directory
5521f15
@BrianHenryIE
Tidy / add debug log when skipping
05c3ade
@BrianHenryIE
Fix DependenciesEnumerator path
056032c
@BrianHenryIE
Add logger to Licenser
87c8ad1
@BrianHenryIE
Add some logging
3ab51ca
@BrianHenryIE
Add logging
d582386
@BrianHenryIE
Add logging to Autoload
c3c2e80
@BrianHenryIE
Add ::testGenerateClassmap() happy path test
0695000
@BrianHenryIE
Add ::testGenerateClassmapParentRelativeDir()
b0329cf
@BrianHenryIE
Improve issue/integration test for Autoload::generateClassmap()
db613d0
@BrianHenryIE
Log / comment / tidy
c3ce0cf
@BrianHenryIE
Add ::testGenerateFilesAutoloader()
98b2650
@BrianHenryIE
Use less $workingDir in paths
8c4da89
@BrianHenryIE
Add more logging to Autoload
6caedbb
@BrianHenryIE
Add info logs to Cleanup
de35728
@BrianHenryIE
Check the lines of the classmap are indented by tabs, not spaced.
7d2c669
@BrianHenryIE
composer require "elazar/flystream":"^0.x-dev"
f00cd28
@BrianHenryIE
Extract builtinsymbols.php array to file
3eb53c0
@BrianHenryIE
Improve logging in FileSymbolScanner
e3c43be
@BrianHenryIE
Use relative paths less
a57f784
@BrianHenryIE
Add another log to FileEnumerator
a6b2080
@BrianHenryIE
Update logs in Copier
dc9f55b
@BrianHenryIE
Add logs to Licenser
63bee2e
@BrianHenryIE
Add logs to Cleanup
4366ca4
@BrianHenryIE
Add --info, --debug, --silent
b96f44d
@BrianHenryIE BrianHenryIE marked this pull request as ready for review February 14, 2025 05:00
@BrianHenryIE BrianHenryIE merged commit e8ec696 into master Feb 14, 2025
8 checks passed
@BrianHenryIE BrianHenryIE mentioned this pull request Feb 16, 2025
Open
@BrianHenryIE BrianHenryIE deleted the add/dry-run branch February 16, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BrianHenryIE