Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Check version job to release workflow #120

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

szepeviktor
Copy link

@BrianHenryIE It is too late because the release is already published, but ...

@BrianHenryIE
Copy link
Owner

I really like this but I don't think it solves the issue completely/in the ideal way. What will happen with this is I will create a release and click publish, then this will give the benefit of a "workflow failed" email for me to act on. I wonder could we expand on this to delete the existing release, capture the content, create the change and then create a new release?! (I'm ad-libbing here). Would that have any impact on Packagist? I.e. I think this repo has a webhook that pushes the release to Packagist, would pushing a new release with the same version number be a problem?

Thanks, as always, for your contributions.

@BrianHenryIE BrianHenryIE merged commit 02247b4 into BrianHenryIE:master Oct 13, 2024
4 of 11 checks passed
@szepeviktor
Copy link
Author

szepeviktor commented Oct 13, 2024

The above forth-and-back "solution" is also error prone.
Moving a git tag causes caching issues on Packagist.
Currently everything begins with the manual creation of a tag+release.

All I can think of is a manual workflow that checks everything and creates a release.
image

This is well-known, frequently seen problem!

@szepeviktor szepeviktor deleted the patch-1 branch October 13, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants