fix: check input options presence when updating config from CLI #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue with config options being overwritten when parsing CLI options.
$input->hasOption
method returnstrue
for every input option that is configured (seeConsole/Commands/Compose@configure
), even when input option is not passed from CLI.Because of that when you are not setting
deleteVendorPackages
option from CLI, the composer.jsonextra
config is overwritten before doing cleanup action. All input options are optional, so to preserveextra
config we should not change values of the config when input option values equals tonull
.