Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary dynamic dispatch. #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/print.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use polib::message::MessageView;
use polib::po_file;
use std::env;
use std::error::Error;
Expand Down
2 changes: 1 addition & 1 deletion src/catalog/iterator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ impl<'a> Iter<'a> {
}

impl<'a> Iterator for Iter<'a> {
type Item = &'a dyn MessageView;
type Item = &'a Message;

fn next(&mut self) -> Option<Self::Item> {
while self.0.index < self.0.catalog.messages.len() {
Expand Down
4 changes: 2 additions & 2 deletions src/catalog/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
mod iterator;

use crate::{
message::CatalogMessageMutView, message::Message, message::MessageKey, message::MessageView,
message::CatalogMessageMutView, message::Message, message::MessageKey,
metadata::CatalogMetadata,
};
pub use iterator::{Iter, IterMut, MessageMutProxy};
Expand Down Expand Up @@ -62,7 +62,7 @@ impl Catalog {
msgctxt: Option<&str>,
msgid: &str,
msgid_plural: Option<&str>,
) -> Option<&dyn MessageView> {
) -> Option<&Message> {
let key = MessageKey::gen(msgctxt, msgid, msgid_plural);
if let Some(&index) = self.map.get(&key) {
Some(self.messages[index].as_ref().unwrap())
Expand Down
2 changes: 1 addition & 1 deletion src/po_file/po_file_writer.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//! Write PO files.

use super::escape::escape;
use crate::catalog::Catalog;
use crate::{catalog::Catalog, message::MessageView};
use std::fs::File;
use std::io::{BufWriter, Write};
use std::path::Path;
Expand Down
1 change: 1 addition & 0 deletions tests/test.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
use polib::catalog::Catalog;
use polib::message::MessageView;
use polib::po_file;
use std::path::Path;

Expand Down
Loading