Feature/BI-750 Create an interface to list all studies that exist for a program #94
Conversation
src/breeding-insight/model/Trial.ts
Outdated
| // import {ProgramObservationLevel} from "@/breeding-insight/model/ProgramObservationLevel"; | ||
| // import {Method} from "@/breeding-insight/model/Method"; | ||
| // import {Scale} from "@/breeding-insight/model/Scale"; |
There was a problem hiding this comment.
Are these needed for anything?
src/breeding-insight/model/Study.ts
Outdated
| // import {ProgramObservationLevel} from "@/breeding-insight/model/ProgramObservationLevel"; | ||
| // import {Method} from "@/breeding-insight/model/Method"; | ||
| // import {Scale} from "@/breeding-insight/model/Scale"; |
There was a problem hiding this comment.
Are these needed for anything?
| } | ||
|
|
||
| try { | ||
| if(!programId) throw new Error('mnissing or invalid program id'); |
| data: T | ||
| --> | ||
| <template v-slot:side-panel="{tableRow}"> | ||
| <TraitDetailPanel |
There was a problem hiding this comment.
Is this suppose to be the StudyDetailPanel?
| - limitations under the License. | ||
| --> | ||
|
|
||
| <template> |
There was a problem hiding this comment.
This appears to be a clone of the TraitDetailPanel, I assume this will be properly implemented with BI-751?
| v-on:show-error-notification="$emit('show-error-notification', $event)" | ||
| > | ||
| <template v-slot="validations"> | ||
| <BaseTraitForm |
There was a problem hiding this comment.
Should this be BaseStudyForm?
| <template> | ||
| <div class="columns is-multiline"> | ||
| <div class="column" v-bind:class="{'is-full': editFormat}"> | ||
| <BasicInputField |
There was a problem hiding this comment.
I assume this will be updated to be specific to studies in BI-751?
| ProgramUsersTable | ||
| } | ||
| }) | ||
| export default class ProgramUserManagement extends ProgramsBase { |
There was a problem hiding this comment.
Class name doesn't match file name
There was a problem hiding this comment.
Per our conversation, experiments has been replaced with studies. All studies are now listed under "Trials and Studies", and the studies for a single trial can be listed by clicking on the name of a trial in the trial list.
| TrialsTable | ||
| } | ||
| }) | ||
| export default class ProgramLocationManagement extends TrialsBase { |
There was a problem hiding this comment.
Class name doesn't match file name
| ]) | ||
| } | ||
| }) | ||
| export default class ProgramManagement extends ProgramsBase { |
There was a problem hiding this comment.
Class name doesn't match file name
| //import TrialsAndExperiments from "@/views/trials-and-studies/TrialsAndExperiments.vue"; | ||
| import TrialsAndStudies from "@/views/trials-and-studies/TrialsAndStudies.vue"; | ||
| //import Experiments from '@/views/trials-and-studies/Experiments.vue'; |
There was a problem hiding this comment.
Can the commented out lines be removed?
Models, DAO, and Services created for Trials and Studies.
Route, views and component tables created for Trials and Studies.