[BI-770, BI-771, BI-727, BI-726] - Fix deactivate link program and user mgmt. Fix Trait numeric validations and min max validation. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timparsons
approved these changes
Mar 30, 2021
| @@ -43,6 +44,8 @@ | |||
| v-bind:value="validMin" | |||
| v-on:input="$emit('min-change', $event)" | |||
| v-bind:field-help="'Numbers only. Decimals ok.'" | |||
| v-bind:validations="clientValidations && clientValidations.scale.validValueMin ? clientValidations.scale.validValueMin : undefined" | |||
| v-bind:server-validations="validationHandler.getValidation(validationIndex, TraitError.MaximumValue)" | |||
There was a problem hiding this comment.
Should this be TraitError.MinimumValue?
| @@ -35,6 +35,8 @@ | |||
| v-bind:value="validMin" | |||
| v-on:input="$emit('min-change', $event)" | |||
| v-bind:field-help="'Leave blank to specify no lower limit.'" | |||
| v-bind:validations="clientValidations && clientValidations.scale.validValueMin ? clientValidations.scale.validValueMin : undefined" | |||
| v-bind:server-validations="validationHandler.getValidation(validationIndex, TraitError.MaximumValue)" | |||
There was a problem hiding this comment.
Same thing with MinimumValue here
ctucker3
commented
Apr 6, 2021
| @@ -26,5 +26,7 @@ export enum TraitError { | |||
| ScaleCategories = "scale.categories", | |||
| Abbreviations = "abbreviations", | |||
| CategoryLabel = "scale.categories.label", | |||
| CategoryValue = "scale.categories.value" | |||
| CategoryValue = "scale.categories.value", | |||
| MinimumValue = "scale.validValueMin", | |||
There was a problem hiding this comment.
Remove this since it isn't used.
nickpalladino
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.