Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BI-690 - Edit existing trait which has observation data #79

Merged
merged 9 commits into from
May 12, 2021

Conversation

nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Feb 24, 2021

Possible future improvements (don't want to spend more time on this currently):

  • caching editable status
  • cancelling editable requests when table row is changed

@nickpalladino nickpalladino marked this pull request as ready for review May 4, 2021 21:58
@nickpalladino nickpalladino requested review from a team, timparsons and ctucker3 and removed request for a team May 4, 2021 21:59
Copy link
Contributor

@ctucker3 ctucker3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, so approving since I am good with this PR once that is fixed.

this.currentTraitEditable = traitEditable;
} catch (error) {
// Display error that traits cannot be loaded
this.$emit('show-error-notification', 'Error while trying to load traits');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message seems incorrect. This is for if the editable endpoint fails right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, thanks I'll update that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed changes

@nickpalladino nickpalladino merged commit f669c2c into develop May 12, 2021
@nickpalladino nickpalladino deleted the feature/BI-690 branch May 12, 2021 15:25
timparsons pushed a commit that referenced this pull request Sep 29, 2021
BI-690 - Edit existing trait which has observation data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants