-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BI-690 - Edit existing trait which has observation data #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment, so approving since I am good with this PR once that is fixed.
this.currentTraitEditable = traitEditable; | ||
} catch (error) { | ||
// Display error that traits cannot be loaded | ||
this.$emit('show-error-notification', 'Error while trying to load traits'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error message seems incorrect. This is for if the editable endpoint fails right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya, thanks I'll update that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed changes
BI-690 - Edit existing trait which has observation data
Possible future improvements (don't want to spend more time on this currently):