Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-698] Import Traits not available until refreshing page after adding self to program #76

Merged
merged 4 commits into from
Feb 25, 2021

Conversation

dmeidlin
Copy link
Contributor

@dmeidlin dmeidlin commented Feb 8, 2021

If the active user is being added to a program then the active user roles are updated as part of the success handler.

Description: Import Traits not available until refreshing page after adding self to program
Component/Version: v0.2
Steps to Reproduce

login as admin

add self to a program

select traits in left navigation bar

Expected result:
Import Traits visible as a selection

Actual Result:
Import traits not visible until the page is refreshed

@github-actions github-actions bot added the bug Something isn't working label Feb 8, 2021
Copy link
Member

@timparsons timparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approving contingent on fixing the build error.

@timparsons timparsons requested a review from DebWeigand February 9, 2021 20:31
Copy link

@DebWeigand DebWeigand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I test this, following the exact steps to reproduce, I can pass this.
But, if I add myself as a 'member' first, and then later edit my role to 'breeder', then I still have to refresh the page to see 'Import Traits'.

@dmeidlin dmeidlin requested a review from DebWeigand February 19, 2021 21:00
@dmeidlin
Copy link
Contributor Author

Ok, the active user role should be updated now when the active user role is edited in program management.

@dmeidlin dmeidlin merged commit 588098c into develop Feb 25, 2021
@dmeidlin dmeidlin deleted the bug/BI-698 branch February 25, 2021 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants