Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-677] - Connect PUT traits to back end #72

Merged
merged 3 commits into from
Feb 12, 2021
Merged

Conversation

ctucker3
Copy link
Contributor

@ctucker3 ctucker3 commented Feb 2, 2021

Hook up the PUT traits on the front end to the backend.

See other PRs:
Breeding-Insight/bi-api#68
Breeding-Insight/sgn#7

Copy link
Member

@nickpalladino nickpalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was playing around editing traits and when I switched from text to ordinal I get a 422 error. Looks like bi-web is not sending categories in the scale info.

image

Copy link
Member

@timparsons timparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving contingent on addressing the comment Nick made earlier about the 422.

@ctucker3
Copy link
Contributor Author

ctucker3 commented Feb 9, 2021

Was playing around editing traits and when I switched from text to ordinal I get a 422 error. Looks like bi-web is not sending categories in the scale info.

image

Good catch! Vue wasn't catching the array update. Changed and pushed.

Copy link
Member

@nickpalladino nickpalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text -> ordinal thing works but I'm seeing some other things on the edit form, maybe we just create a new card to fix bugs with the form? If I try to edit and change from ordinal to nominal, it doesn't seem to change.

@ctucker3
Copy link
Contributor Author

The text -> ordinal thing works but I'm seeing some other things on the edit form, maybe we just create a new card to fix bugs with the form? If I try to edit and change from ordinal to nominal, it doesn't seem to change.

Yeah I like that idea. Made a card fir it:

https://breedinginsight.atlassian.net/browse/BI-735

@ctucker3 ctucker3 merged commit dec8946 into develop Feb 12, 2021
@ctucker3 ctucker3 deleted the feature/BI-677 branch February 12, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants