-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BI-563] Archive Individual Trait #70
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d6f6c31
[BI-563-1] make dev port for bi-web unique
dmeidlin 8da53ca
[BI-563-1] activate WarningModal when archive event fired from TraitD…
dmeidlin ad0f65e
[BI-563-1] display active program name in warning modal for archive
dmeidlin 7708d2b
[BI-563-1] close details pane when archive confirmed
dmeidlin 163b205
[BI-563-1] add restore/unarchive link to detail panel
dmeidlin a1fafaa
[BI-563-1] go to page 1 of trait list after confrming archive
dmeidlin 349f760
[BI-563-1] show success notification after trait archiving
dmeidlin 263819a
[BI-563-1] add archive tag to to bottom of trait detail panel
dmeidlin a75bb07
[BI-563-1] show archived tag on trait table row
dmeidlin 2f47011
[BI-563-1] fix check for absence of trait id in trait service
dmeidlin 0859784
[BI-563-1] update traits on backend when archiving
dmeidlin 4977594
[BI-563-1] substitute remove/restore in user prompts for correspondin…
dmeidlin 6e6d619
[BI-563] use archivable flag
dmeidlin dc07223
[BI-563] fix input type
dmeidlin d5213b3
[BI-563] fix type issue
dmeidlin e95a7fb
[BI-563] change verbage remove to archive
dmeidlin 3714efa
[BI-732] finish up archive traits on front end
6d2a5eb
[BI-563] remove unnecessary archivable flag check
dmeidlin 889debb
[BI-563] change dev port to 8080
dmeidlin edaa341
[BI-563] return to first page after archiving trait
dmeidlin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -480,3 +480,8 @@ div.sentence-input { | |
fill: none; | ||
stroke-width: 2; | ||
} | ||
|
||
.archive-tag { | ||
background: lightgray; | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never knew that was a way to clone! There is also the
Trait.assign
function in the trait object if you want a trait class instance.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assign would probably work in this case, but I generally stay away from it because it can cause errors if a property of interest is deeply nested (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign).
Also, I remember seeing a comparison of computational effort required for the JSON parsing method for deep cloning versus using methods in underscore or other libraries, and JSON parsing came out on top, so I generally use it for cloning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. Just to clarify, the
Trait.assign
is a custom function of ours that is implemented in our classes.