[BI-683, BI-678, BI-670] - Numerical, Text, Duration scale forms #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctucker3
force-pushed
the
feature/BI-683
branch
from
d450e39 to
95c5cd8
Compare
ctucker3
commented
Dec 9, 2020
|
|
||
| this.trait!.scale!.decimalPlaces = undefined; | ||
| this.trait!.scale!.validValueMin = undefined; | ||
| this.trait!.scale!.validValueMax = undefined; | ||
| this.trait!.scale!.dataType = value; |
There was a problem hiding this comment.
No need to pay too much attention to this method. It changes in the next PR to add the scale history.
timparsons
approved these changes
Dec 9, 2020
nickpalladino
approved these changes
Dec 9, 2020
| v-bind:field-name="'Minimum Valid Value'" | ||
| v-bind:value="validMin" | ||
| v-on:input="$emit('min-change', $event)" | ||
| v-bind:field-help="'Numbers only. Decimals ok.'" |
There was a problem hiding this comment.
When it comes to brapi, have an issue plantbreeding/BrAPI#450 open for min/max which would be relevant to decimals here. I guess more of a note that we'll have to deal with that when we get there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off other PR, BI-671 so will include extra file changes.