BI-2373 Add Delete Option to Germplasm Lists View

[dmeidlin]

Description

Story: BI-2373

Dependencies

BI-2372 BI-2374

Testing

• Import a germplasm list to a project
• navigate to the project's germplasm lists table and click on the details link for the imported list
• in the list details table click on manage-list and select delete
• verify that the list no longer appears in the lists table
• navigate to the all-germplasm tab and verify that the individual germplasm contained in the deleted list are still present

Checklist:

• I have performed a self-review of my own code
• I have tested my code and ensured it meets the acceptance criteria of the story
• [] I have create/modified unit tests to cover this change
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to documentation
• I have run TAF: <link to TAF run>
• I have run SiteImprove on pages impacted by changes

[HMS17]

A couple comments

[mlm483]

In addition to my comments, one thing to consider is making the list name a link to the list detail view rather than having a separate "Details" action stacked on top of "Download". I think it would make the UI easier to navigate.

[mlm483]

Because the system treats list names as case-sensitive for validation purposes, I would not alter the casing for display. For example, I can upload lists called "yhh" and "Yhh", but when I try to upload a third list with the name "Yhh", I get the validation error, "Error: Import group name already exists".

[dmeidlin]

The edit on line 26 just fixes the old filter syntax that was throwing an error. The filter has the same functionality and list names are still displayed with case sensitivity as in the image, so I don't think there is any change needed here.

[mlm483]

My initial comment may have been unclear, I'm talking about the <h1> on the germplasm by list view. In this screenshot, you can see how the list of lists view shows the case-sensitive names, but the germplasm by list view uses toStartCase. I recommend removing the call to toStartCase on line 26 of GermplasmByList.vue.

[dmeidlin]

Agreed. I removed the filter.

[dmeidlin]

In addition to my comments, one thing to consider is making the list name a link to the list detail view rather than having a separate "Details" action stacked on top of "Download". I think it would make the UI easier to navigate.

That's a valid point. I would bring this up at a meeting and at least let @shawnyarnes weigh in since it's a UI change, rather than tacking it on to this feature where the scope doesn't really overlap.