Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BI-2328] Experimental observation file import removes periods from column headers #411

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[BI-2328] Experimental observation file import removes periods from column headers #411

merged 1 commit into from
Oct 31, 2024

Conversation

davedrp
Copy link
Contributor

@davedrp davedrp commented Oct 31, 2024 •
edited by jira bot
Loading

Description

BI-2328 Experimental observation file import removes periods from column headers

Change the link for the Ontology Import template to point to the new version (with "No periods are allowed" added to the name discription)

Dependencies

bi-api : bug/BI-2328_fix

Testing

insure that the ontology template button retrieves bi_ontology_template_v15_2024-10-09.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@davedrp davedrp requested review from a team, nickpalladino and HMS17 and removed request for a team October 31, 2024 17:49
@github-actions github-actions bot added the bug Something isn't working label Oct 31, 2024
@mlm483 mlm483 self-requested a review October 31, 2024 17:51
@mlm483 mlm483 self-assigned this Oct 31, 2024
mlm483
mlm483 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working. The v15 template file, bi_ontology_template_v15_2024-10-09.xls was downloaded.

@davedrp davedrp merged commit aa36f80 into release/1.0 Oct 31, 2024
2 checks passed
@davedrp davedrp deleted the bug/BI-2328_2 branch October 31, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlm483 mlm483 mlm483 approved these changes

@HMS17 HMS17 HMS17 approved these changes

@nickpalladino nickpalladino Awaiting requested review from nickpalladino nickpalladino was automatically assigned from Breeding-Insight/dev-team

Assignees

@mlm483 mlm483

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davedrp @HMS17 @mlm483