Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BI-2304 - Support Duplicate Germplasm in Lists Referencing Existing Germplasm #399

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

mlm483
Copy link
Contributor

@mlm483 mlm483 commented Sep 11, 2024

Description

Story: https://breedinginsight.atlassian.net/browse/BI-2304

Since the listEntryNumbers additionalInfo key was removed in the back end change, I updated the front end to rely on importEntryNumber alone for display.

bi-api PR: Breeding-Insight/bi-api#401
BrAPI-Java-TestServer PR: Breeding-Insight/brapi-Java-TestServer#35

Dependencies

bi-api branch: feature/BI-2304
BrAPI-Java-TestServer branch: feature/BI-2304

Testing

See testing section in the bi-api PR.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@mlm483 mlm483 requested review from dmeidlin and HMS17 September 23, 2024 19:07
@HMS17 HMS17 assigned HMS17 and unassigned dmeidlin Sep 25, 2024
@mlm483 mlm483 merged commit 823fd80 into develop Oct 7, 2024
1 check passed
@mlm483 mlm483 deleted the feature/BI-2304 branch October 7, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants