Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-2302] - Fix wonky colors #398

Merged
merged 2 commits into from
Sep 6, 2024
Merged

[BI-2302] - Fix wonky colors #398

merged 2 commits into from
Sep 6, 2024

Conversation

HMS17
Copy link
Contributor

@HMS17 HMS17 commented Sep 5, 2024

Description

Story: BI-2302 - Fix wonky colors

Small change to make text color of summary details for an experimental dataset properly contrasted against background

Dependencies

n/a

Testing

Navigate to experiment details page
Ensure that the summary details for a dataset are in dark rather than green font
Ensure that contrast of summary details to background passes WAVE AA standard

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Sep 5, 2024
@HMS17 HMS17 marked this pull request as ready for review September 6, 2024 15:25
@HMS17 HMS17 requested review from a team, davedrp and nickpalladino and removed request for a team September 6, 2024 15:25
Copy link
Member

@nickpalladino nickpalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contrast looks good and site improve doesn't have any issues with it. The card mentions dark green matching the line on the message box but it seems to be more of a black. Should it be dark green?

@HMS17
Copy link
Contributor Author

HMS17 commented Sep 6, 2024

Contrast looks good and site improve doesn't have any issues with it. The card mentions dark green matching the line on the message box but it seems to be more of a black. Should it be dark green?

After talking with Shawn re examples already existing in DeltaBreed she decided on the black over the dark green.

@nickpalladino
Copy link
Member

sounds good

@HMS17 HMS17 merged commit 1a514f6 into develop Sep 6, 2024
1 check passed
@HMS17 HMS17 deleted the bug/BI-2302 branch September 6, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants