BI-2152 - Experimental Collaborator Front-end Permissions #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davedrp
requested review from
a team,
nickpalladino and
mlm483
and removed request for
a team
mlm483
approved these changes
Aug 29, 2024
| <router-link | ||
| v-bind:to="{name: 'germplasm', params: {programId: activeProgram.id}}" | ||
| :id="germplasmMenuId" | ||
| v-if="$ability.can('access', 'Germplasm')" |
There was a problem hiding this comment.
Why is there a v-if on this router-link but not the others? You might consider standardizing.
davedrp
force-pushed
the
feature/BI-2152
branch
from
e9955fe to
b353317
Compare
nickpalladino
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BI-2152 - Experimental Collaborator Front-end Permissions
Changes made
Hide all menu items except for home, experiments and observations, BrAPI
AppAbility.tsto correspond to options in the side-bar menu.ability.tsadd role permission list for experimentalcollaborator, also mad the roll permission list explicit for readonly.Restrict Manage Experiments menu
can('create', 'Collaborator');to programadministrator and systemadministrator inability.ts.ExperimentDetails.vueto includethis.$ability.can('create', 'Collaborator').Dependencies
bi-api: develop branch
Testing
Expected result
The Side-bar Menu should have only three options:
Expected result
Checklist: